EricGao888 commented on code in PR #13550:
URL:
https://github.com/apache/dolphinscheduler/pull/13550#discussion_r1112561652
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java:
##########
@@ -88,7 +88,7 @@ public class MasterConfig implements Validator {
private double maxCpuLoadAvg = -1;
private double reservedMemory = 0.3;
private Duration failoverInterval = Duration.ofMinutes(10);
- private boolean killYarnJobWhenTaskFailover = true;
+ private boolean killApplicationWhenTaskFailover = true;
Review Comment:
Just curious, why do we set the default value of
`killApplicationWhenTaskFailover ` to `true`? If we set it to `false`, will DS
continue to track the running application started before and keep idempotence
when failover done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
