Radeity commented on code in PR #13550:
URL:
https://github.com/apache/dolphinscheduler/pull/13550#discussion_r1112632019
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java:
##########
@@ -88,7 +88,7 @@ public class MasterConfig implements Validator {
private double maxCpuLoadAvg = -1;
private double reservedMemory = 0.3;
private Duration failoverInterval = Duration.ofMinutes(10);
- private boolean killYarnJobWhenTaskFailover = true;
+ private boolean killApplicationWhenTaskFailover = true;
Review Comment:
Get your point, now, DS will not keep tracking running application, and
directly set status of taskInstance to `NEED_FAULT_TOLERANCE`, so the default
value sets `true`. Maybe the failover logic can be optimized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
