Radeity commented on PR #13930:
URL:
https://github.com/apache/dolphinscheduler/pull/13930#issuecomment-1510828936
> I think its better to fix this k8s command related stuff in this PR.
>
> Technically, we don't want to make any changes to the user's command, we
should keep the quotes of the user command. E.g.
>
> ```
> echo `ls`
> echo "${var}"
> perl -Mbignum=bpi -wle 'print bpi(2000)'
> ```
Hi, @rickchengx , actually, i don't change user's command. Quotes are only
used to split the command, like `perl -Mbignum=bpi -wle 'print bpi(2000)'`, we
can use `perl -Mbignum=bpi -wle "print bpi(2000)"`, either.
If we keep the quotes, such as echo "123", user may want to print 123, but
we get command and print "123" with unexpected quotes.
```
- command:
- echo
- '"123"'
```
What this PR does is to generate command array: ["echo", "123"], rather,
["echo", "\\"123\\""].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
