Radeity commented on PR #13930:
URL: 
https://github.com/apache/dolphinscheduler/pull/13930#issuecomment-1511102595

   > We can not remove the quotes of the user command. E.g.,
   > 
   > ```
   > cat file.txt | grep "some word"
   > ```
   > 
   > if the quotes are removed as follow:
   > 
   > ```
   > cat file.txt | grep some word
   > ```
   > 
   > We'll get the error `grep: word: No such file or directory`
   
   Hi, @rickchengx , maybe i don't explain it clearly before, after removing 
quotes, the command will still be `cat file.txt | grep "some word"`, cuz each 
element in this array is considered as a string. If we don't remove it, the 
executed command will be cat file.txt | grep ""some word"" and will get the 
error `grep: word: No such file or directory`.
   
   > Maybe we can try /bin/bash -c "user_command", WDYT
   
   Do you mean set it as default that command is `/bin/bash -c` and args are 
user commands? I think there will be some problems, like `/bin/bash` is not 
always effective, sometimes it should use `/bin/sh`, there must be other 
scenarios which are not suitable for this way. So i think we should keep the 
original way and let user set commands and args by themselves, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to