Radeity commented on code in PR #13939:
URL:
https://github.com/apache/dolphinscheduler/pull/13939#discussion_r1168552460
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java:
##########
@@ -306,6 +312,12 @@ public void cancelApplication() throws
InterruptedException {
return;
}
+ if (StringUtils.isNotBlank(appId)) {
+ String commandFile = String.format("%s/%s.kill",
taskRequest.getExecutePath(), appId);
+
YarnApplicationManager.execYarnKillCommand(taskRequest.getTenantCode(), appId,
commandFile,
+ "yarn application -kill " + appId);
+ }
+
Review Comment:
We don't have to kill yarn application here, like other yarn tasks(Spark,
Flink, etc), plz remove code changes in `AbstractCommandExecutor`.
In addition, i will improve the code logic of killing application in later
PR, it seems a bit messy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
