rickchengx commented on code in PR #13939:
URL:
https://github.com/apache/dolphinscheduler/pull/13939#discussion_r1170739255
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -160,7 +170,17 @@ public void handle(TaskCallBack taskCallBack) throws
TaskException {
// run datax processDataSourceService
String jsonFilePath = buildDataxJsonFile(paramsMap);
- String shellCommandFilePath = buildShellCommandFile(jsonFilePath,
paramsMap);
+ String shellCommandFilePath;
+ if (dataXParameters.getYarn() == 1) {
Review Comment:
A bit misleading if `yarn` is a numeric type.
Maybe use enum or Boolean to represent whether to use yarn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
