imay commented on a change in pull request #1816: v2 segment support string
encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r325261462
##########
File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp
##########
@@ -173,6 +189,7 @@ Status BinaryDictPageDecoder::init() {
}
RETURN_IF_ERROR(_data_page_decoder->init());
+ RETURN_IF_ERROR(_dict_decoder->init());
Review comment:
if encoding_type is plain, _dict_decoder is nullptr. That will lead to crash
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
