imay commented on a change in pull request #1816: v2 segment support string
encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r329392626
##########
File path: be/src/olap/rowset/segment_v2/column_reader.cpp
##########
@@ -426,6 +431,20 @@ Status FileColumnIterator::_read_page(const
OrdinalPageIndexIterator& iter, Pars
RETURN_IF_ERROR(_reader->encoding_info()->create_page_decoder(data,
options, &page->data_decoder));
RETURN_IF_ERROR(page->data_decoder->init());
+ if (_reader->encoding_info()->encoding() == DICT_ENCODING) {
Review comment:
Better to add comment to explain why we create dict decoder lazily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
