imay commented on a change in pull request #1818: Add frame_of_reference page
URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327081333
##########
File path: be/src/util/frame_of_reference_coding.h
##########
@@ -44,7 +42,8 @@ struct ForCoding {
// 1. Body:
// BitPackingFrame * FrameCount
// 2. Footer:
-// FrameOffset(4) * (FrameCount + 1)
+// BitWidth(1) * FrameCount
+// OrderFlag(1) * FrameCount
Review comment:
should add some comment for BitWidth and OrderFlag, If OrderFlag is bool why
not store it as a bitmap?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
