imay commented on a change in pull request #1818: Add frame_of_reference page
URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327078671
##########
File path: be/src/util/frame_of_reference_coding.cpp
##########
@@ -68,13 +68,44 @@ void ForEncoder<T>::put_batch(const T *in_data, size_t
count) {
_count += count;
}
+// todo(kks): improve this method by SIMD instructions
+template <typename T>
+void ForEncoder<T>::pack(T* input, uint8_t in_num, uint8_t* pout, int
bit_width) {
Review comment:
Add some comments for this function, for its work and it argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
