kangkaisen commented on a change in pull request #1818: Add frame_of_reference
page
URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r327407015
##########
File path: be/src/util/frame_of_reference_coding.h
##########
@@ -44,7 +42,8 @@ struct ForCoding {
// 1. Body:
// BitPackingFrame * FrameCount
// 2. Footer:
-// FrameOffset(4) * (FrameCount + 1)
+// BitWidth(1) * FrameCount
+// OrderFlag(1) * FrameCount
Review comment:
Currently, we only improve for ascending order sequence. I'm not sure
whether we need to improve for descending order sequence in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
