chaoyli commented on a change in pull request #1775: add predicate filter(#1652)
URL: https://github.com/apache/incubator-doris/pull/1775#discussion_r328587302
##########
File path: be/src/olap/in_list_predicate.cpp
##########
@@ -84,18 +84,51 @@ void CLASS<type>::evaluate(VectorizedRowBatch* batch)
const { \
IN_LIST_PRED_EVALUATE(InListPredicate, !=)
IN_LIST_PRED_EVALUATE(NotInListPredicate, ==)
+#define IN_LIST_PRED_COLUMN_BLOCK_EVALUATE(CLASS, OP) \
+ template<class type> \
+ void CLASS<type>::evaluate(ColumnBlock* block, SelectionVector*
selector_vector) const { \
+ if (block->is_nullable()) { \
+ for (int i = 0; i < block->nrows(); ++i) { \
+ if (!selector_vector->is_row_selected(i)) { \
Review comment:
I think SelectionVector is use array will be better to remove branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
