chaoyli commented on a change in pull request #1775: add predicate filter(#1652)
URL: https://github.com/apache/incubator-doris/pull/1775#discussion_r335453703
##########
File path: be/src/olap/generic_iterators.cpp
##########
@@ -148,22 +150,23 @@ class MergeIteratorContext {
RowBlockV2 _block;
bool _valid = false;
- size_t _index_in_block = 0;
+ size_t _index_in_block = -1;
};
Status MergeIteratorContext::init(const StorageReadOptions& opts) {
RETURN_IF_ERROR(_iter->init(opts));
RETURN_IF_ERROR(_load_next_block());
+ if (valid()) {
+ RETURN_IF_ERROR(advance());
Review comment:
why this place to get another block, it may be consume more memory in init()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
