imay commented on a change in pull request #1900: Fix parquet_scanner_test in
debug mode
URL: https://github.com/apache/incubator-doris/pull/1900#discussion_r329048308
##########
File path: be/src/exec/base_scanner.cpp
##########
@@ -154,10 +154,10 @@ bool BaseScanner::fill_dest_tuple(const Slice& line,
Tuple* dest_tuple, MemPool*
ctx->clear_error_msg();
return false;
}
- SlotDescriptor* slot_descriptor =
_src_slot_descs_order_by_dest[dest_index];
- if (_strict_mode && (slot_descriptor != nullptr)&&
!_src_tuple->is_null(slot_descriptor->null_indicator_offset())) {
+ if (_strict_mode && (_src_slot_descs_order_by_dest[dest_index] !=
nullptr) &&
Review comment:
better leave a comment for this change, I'm afraid other will change it back
someday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
