imay commented on issue #2075: Segment v2 stream load core dump(#2037) URL: https://github.com/apache/incubator-doris/pull/2075#issuecomment-547252243 > @imay > > 1. I think move release and add finish_and_release is ok > > 2. BitShuffleBuilder using fastring,other PageBuilder using faststring too,here I'm not quite sure just other PageBuilder may has the same problem,so it's better to fix them all; When we determine these interfaces, we should not consider the specific implementation. So first of all, we should discuss to agree on what's the meaning of all function interfaces. > > 3. I just don't understand what does 'keep release and finish consistent' mean,that means pageBuilder.finish using faststring.release to return? What I want to express is that the `release` content is what `finish` function returns. Class user don't care about its implementation detail. If we can make BitShufflePageBuilder work in this way, then do we really need to add the `finish_and_release` interface?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
