imay commented on issue #2075: Segment v2 stream load core dump(#2037) URL: https://github.com/apache/incubator-doris/pull/2075#issuecomment-547274966 > My suggestion is to combine `Slice finish()` and `Slice release()` into `OwnedSlice finish()`. `OwnedSlice` owns slice's data and is a move-only type. This will make ownership transfer clear and remove all potential bugs. This is an option. But if we use adopt it, user can call `finish` only one time. I'm not sure if it is convenient for all use scenarios.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
