gaodayue commented on a change in pull request #2075: Segment v2 stream load
core dump(#2037)
URL: https://github.com/apache/incubator-doris/pull/2075#discussion_r341430722
##########
File path: be/src/olap/rowset/segment_v2/page_builder.h
##########
@@ -75,9 +70,8 @@ class PageBuilder {
// This api is for release the resource owned by builder
// It means it will transfer the ownership of some resource to other.
- // This api is always called after finish
- // and should be followed by reset() before reuse the builder
- virtual void release() = 0;
+ // This api should be followed by reset() before reuse the builder
+ virtual OwnedSlice release() = 0;
Review comment:
`finish()` is a better name and you should move the method declaration right
after `add()` and before `reset()`to be consistent with the order of invocation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
