gaodayue commented on a change in pull request #2075: Segment v2 stream load core dump(#2037) URL: https://github.com/apache/incubator-doris/pull/2075#discussion_r341433603
########## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ########## @@ -32,6 +32,7 @@ #include "runtime/mem_tracker.h" #include "gen_cpp/segment_v2.pb.h" #include "gutil/hash/string_hash.h" +#include <util/owned_slice.h> Review comment: Remove this line after `OwnedSlice` is moved into `slice.h`. In addition I want to point out that we use `#include <>` only for standard and third-party library. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
