imay commented on a change in pull request #2310: Marising
URL: https://github.com/apache/incubator-doris/pull/2310#discussion_r351168768
 
 

 ##########
 File path: be/src/olap/schema_change.cpp
 ##########
 @@ -363,8 +388,7 @@ bool RowBlockChanger::change_row_block(
                     return false;
                 }
 
-                if (mutable_block->tablet_schema().column(i).type() <
-                        ref_block->tablet_schema().column(ref_column).type()) {
+                if ( newtype < reftype ) {
 
 Review comment:
   ```suggestion
                   if (newtype < reftype) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to