imay commented on a change in pull request #2310: Marising
URL: https://github.com/apache/incubator-doris/pull/2310#discussion_r351159629
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -263,11 +263,13 @@ bool RowBlockChanger::change_row_block(
for (size_t i = 0, len = mutable_block->tablet_schema().num_columns();
!filter_all && i < len; ++i) {
int32_t ref_column = _schema_mapping[i].ref_column;
+ FieldType reftype =
ref_block->tablet_schema().column(ref_column).type();
+ FieldType newtype = mutable_block->tablet_schema().column(i).type();
+
if (_schema_mapping[i].ref_column >= 0) {
// new column will be assigned as referenced column
// check if the type of new column is equal to the older's.
- if (mutable_block->tablet_schema().column(i).type()
- == ref_block->tablet_schema().column(ref_column).type()) {
+ if ( newtype == reftype ) {
Review comment:
we perfer no space between `()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
