kangkaisen commented on a change in pull request #2308: Add BinaryPrefixPage
URL: https://github.com/apache/incubator-doris/pull/2308#discussion_r351648204
##########
File path: be/src/olap/rowset/segment_v2/bitshuffle_page.h
##########
@@ -186,6 +203,8 @@ class BitshufflePageBuilder : public PageBuilder {
bool _finished;
faststring _data;
faststring _buffer;
+ CppType _first_value;
+ CppType _last_value;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]