kangkaisen commented on a change in pull request #2308: Add BinaryPrefixPage
URL: https://github.com/apache/incubator-doris/pull/2308#discussion_r351710921
##########
File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
##########
@@ -107,19 +113,46 @@ class BinaryPlainPageBuilder : public PageBuilder {
return _size_estimate;
}
+ Status get_first_value(void* value) const override {
+ DCHECK(_finished);
+ if (_offsets.size() == 0) {
+ return Status::NotFound("page is empty");
+ }
+ *reinterpret_cast<Slice*>(value) = Slice(_first_value);
+ return Status::OK();
+ }
+ Status get_last_value(void* value) const override {
+ DCHECK(_finished);
+ if (_offsets.size() == 0) {
+ return Status::NotFound("page is empty");
+ }
+ *reinterpret_cast<Slice*>(value) = Slice(_last_value);
+ return Status::OK();
+ }
+
void update_prepared_size(size_t added_size) {
_prepared_size += added_size;
_prepared_size += sizeof(uint32_t);
}
private:
+ void _copy_value_at(faststring& value, size_t idx) const {
Review comment:
oh. I know it but forgot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
