imay commented on a change in pull request #2293: Support Grouping Sets, Rollup
and Cube to extend group by statement
URL: https://github.com/apache/incubator-doris/pull/2293#discussion_r352284332
##########
File path: fe/src/main/java/org/apache/doris/analysis/Expr.java
##########
@@ -361,7 +361,9 @@ public final void analyze(Analyzer analyzer) throws
AnalysisException {
computeNumDistinctValues();
// Do all the analysis for the expr subclass before marking the Expr
analyzed.
- analyzeImpl(analyzer);
+ if (analyzer != null) {
Review comment:
why need check `analyzer != null`, please comment for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
