imay commented on a change in pull request #2293: Support Grouping Sets, Rollup
and Cube to extend group by statement
URL: https://github.com/apache/incubator-doris/pull/2293#discussion_r352284401
##########
File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
##########
@@ -632,7 +633,7 @@ public void analyzeImpl(Analyzer analyzer) throws
AnalysisException {
for (int i = 0; i < argTypes.length; ++i) {
// For varargs, we must compare with the last type in
callArgs.argTypes.
int ix = Math.min(args.length - 1, i);
- if (!argTypes[i].matchesType(args[ix]) &&
!(argTypes[i].isDateType() && args[ix].isDateType())) {
+ if (!argTypes[i].matchesType(args[ix]) && !(
argTypes[i].isDateType() && args[ix].isDateType())) {
Review comment:
```suggestion
if (!argTypes[i].matchesType(args[ix]) &&
!(argTypes[i].isDateType() && args[ix].isDateType())) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
