imay commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247 URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353046947
########## File path: be/src/agent/heartbeat_server.cpp ########## @@ -147,6 +147,10 @@ Status HeartbeatServer::_heartbeat( _master_info->__set_http_port(master_info.http_port); } + if (master_info.__isset.heartbeat_flag) { + _olap_engine->set_heartbeat_flag(master_info.heartbeat_flag); Review comment: I prefer that we store this flag in exec_env, class who has the requirement access the flag it needs. If changing in your way, there is no place to see what's the flags is. And what's more, if someone needs this flags, it will be set here, which is high coupling. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org