imay commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247 URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353687020
########## File path: be/src/olap/schema_change.cpp ########## @@ -1123,6 +1125,10 @@ bool SchemaChangeWithSorting::_internal_sorting(const vector<RowBlock*>& row_blo context.partition_id = new_tablet->partition_id(); context.tablet_schema_hash = new_tablet->schema_hash(); context.rowset_type = new_rowset_type; + HeartbeatFlags* heartbeat_flags = ExecEnv::GetInstance()->heartbeat_flags(); Review comment: better pass rowset_type by caller ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org