morningman commented on a change in pull request #2477: [PROPOSAL]Support
Dynamic Partition(adapt GSON serialize)
URL: https://github.com/apache/incubator-doris/pull/2477#discussion_r361673723
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -5035,6 +5074,35 @@ public void replayRenameColumn(TableInfo tableInfo)
throws DdlException {
throw new DdlException("not implmented");
}
+ public void modifyTableDynamicPartition(Database db, OlapTable table,
Map<String, String> properties) throws DdlException {
+ Map<String, String> analyzedDynamicPartition =
DynamicPartitionUtil.analyzeDynamicPartition(db, table, properties);
+ TableProperty tableProperty = table.getTableProperty();
+ if (tableProperty != null) {
Review comment:
I think even if tableProperty is null, we can create a new table property to
set dynamic partition properties, just like adding dynamic partition properties
to a table at runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
