morningman commented on a change in pull request #2477: [PROPOSAL]Support
Dynamic Partition(adapt GSON serialize)
URL: https://github.com/apache/incubator-doris/pull/2477#discussion_r362493280
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -1177,6 +1190,10 @@ private void startMasterOnlyDaemonThreads() {
// start routine load scheduler
routineLoadScheduler.start();
routineLoadTaskScheduler.start();
+ // start dynamic partition task
+ if (Config.dynamic_partition_enable) {
+ dynamicPartitionScheduler.start();
Review comment:
you make the config `dynamic_partition_enable` mutable at runtime, but here
you do not start the thread if `dynamic_partition_enable` is false when FE
starting up. Then even if you change this config to true at runtime, the thread
will not start.
You should just let this thread start, but check the
`dynamic_partition_enable` at every loop of the dynamic partition scheduling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
