imay commented on a change in pull request #2691: add rowset state
URL: https://github.com/apache/incubator-doris/pull/2691#discussion_r364262487
##########
File path: be/src/olap/rowset/rowset.h
##########
@@ -152,8 +268,13 @@ class Rowset : public
std::enable_shared_from_this<Rowset> {
bool _is_pending; // rowset is pending iff it's not in visible state
bool _is_cumulative; // rowset is cumulative iff it's visible and start
version < end version
- DorisCallOnce<OLAPStatus> _load_once;
+ SpinLock _lock;
+ Mutex _load_lock;
bool _need_delete_file = false;
+ // variable to indicate how many rowset readers owned this rowset
+ std::atomic<uint64_t> _refs_by_reader;
+ // rowset state machine
+ RowsetStateMachine _rowset_state_machine;
Review comment:
should be given a default value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
