imay commented on a change in pull request #2691: add rowset state
URL: https://github.com/apache/incubator-doris/pull/2691#discussion_r364675628
##########
File path: be/src/olap/rowset/alpha_rowset.cpp
##########
@@ -51,7 +51,8 @@ OLAPStatus AlphaRowset::do_load(bool use_cache) {
return OLAP_SUCCESS;
}
-OLAPStatus AlphaRowset::do_create_reader(std::shared_ptr<RowsetReader>*
result) {
+OLAPStatus AlphaRowset::create_reader(std::shared_ptr<RowsetReader>* result) {
+ MutexLock release_lock(&_lock);
Review comment:
why lock? I think you should call load to make sure rowset is loaded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
