lingbin commented on a change in pull request #2792: Reformat BE code 1/7
URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368278813
##########
File path: be/src/agent/user_resource_listener.cpp
##########
@@ -64,16 +61,15 @@ void UserResourceListener::update_users_resource(int64_t
new_version) {
}
// Call fe to get latest user resource
Status master_status;
- // using 500ms as default timeout value
+ // using 500ms as default timeout value
FrontendServiceConnection client(_exec_env->frontend_client_cache(),
- _master_info.network_address,
- config::thrift_rpc_timeout_ms,
- &master_status);
+ _master_info.network_address,
config::thrift_rpc_timeout_ms,
+ &master_status);
TFetchResourceResult new_fetched_resource;
- if (!master_status.ok()) {
- LOG(ERROR) << "Get frontend client failed, with address:"
- << _master_info.network_address.hostname << ":"
- << _master_info.network_address.port;
+ if (!master_status.ok()) {
+ LOG(ERROR) << "Get frontend client failed, with address:"
+ << _master_info.network_address.hostname << ":"
Review comment:
Similar to the previous indentation problem, alignment with the "<<" on the
previous line should not be mandatory, 8 spaces should be allowed.
BTW: here there is only 4 spaces, so need to be changed one of the two ways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
