lingbin commented on a change in pull request #2792: Reformat BE code 1/7
URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368275407
##########
File path: be/src/agent/pusher.cpp
##########
@@ -178,18 +176,16 @@ AgentStatus Pusher::process(vector<TTabletInfo>*
tablet_infos) {
if (st.ok() && !is_timeout) {
double rate = -1.0;
if (_push_req.__isset.http_file_size) {
- rate = (double) _push_req.http_file_size / (cost / 1000 / 1000
/ 1000) / 1024;
+ rate = (double)_push_req.http_file_size / (cost / 1000 / 1000
/ 1000) / 1024;
}
LOG(INFO) << "down load file success. local_file=" <<
_local_file_path
- << ", remote_file=" << _remote_file_path
- << ", tablet_id" << _push_req.tablet_id
- << ", cost=" << cost / 1000 << "us, file_size" <<
_push_req.http_file_size
- << ", download rage:" << rate << "KB/s";
+ << ", remote_file=" << _remote_file_path << ", tablet_id"
+ << _push_req.tablet_id << ", cost=" << cost / 1000 <<
"us, file_size"
+ << _push_req.http_file_size << ", download rage:" <<
rate << "KB/s";
Review comment:
In places like this, trying to get as many lines as possible is not a good
idea.
On the contrary, the one-to-one method(like before) is easier to read, Is
there a way to avoid it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
