gaodayue commented on a change in pull request #3271: [Bug] Avoid compacting
recently added rowset
URL: https://github.com/apache/incubator-doris/pull/3271#discussion_r404778443
##########
File path: be/src/olap/rowset/rowset.cpp
##########
@@ -65,6 +67,9 @@ void Rowset::make_visible(Version version, VersionHash
version_hash) {
_rowset_meta->set_version(version);
_rowset_meta->set_version_hash(version_hash);
_rowset_meta->set_rowset_state(VISIBLE);
+ // update create time to the visible time,
+ // it's used to skip recently published version during compaction
+ _rowset_meta->set_creation_time(time(nullptr));
Review comment:
You mean `UnixMillis() / 1000`? Any reason for that, it seems more verbose
than time(nullptr).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
