gaodayue commented on a change in pull request #3271: [Bug] Avoid compacting
recently added rowset
URL: https://github.com/apache/incubator-doris/pull/3271#discussion_r405241070
##########
File path: be/src/olap/rowset/rowset.cpp
##########
@@ -65,6 +67,9 @@ void Rowset::make_visible(Version version, VersionHash
version_hash) {
_rowset_meta->set_version(version);
_rowset_meta->set_version_hash(version_hash);
_rowset_meta->set_rowset_state(VISIBLE);
+ // update create time to the visible time,
+ // it's used to skip recently published version during compaction
+ _rowset_meta->set_creation_time(time(nullptr));
Review comment:
OK, I'll use functions in util/time.h instead. However I don't think
monotonic time is appropriate here for two reasons
1. Previous rowsets use unix timestamp as `creation_time`, switch to
monotonic time will break other parts of code that uses that field
2. Monotonic time may go backward after system reboot, which is not suitable
for persistence
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
