imay commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427170693
##########
File path: be/CMakeLists.txt
##########
@@ -264,7 +264,7 @@ check_function_exists(sched_getcpu HAVE_SCHED_GETCPU)
# -fno-omit-frame-pointers: Keep frame pointer for functions in register
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall -Wno-sign-compare
-Wno-unknown-pragmas -pthread")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-strict-aliasing
-fno-omit-frame-pointer")
-set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++11 -D__STDC_FORMAT_MACROS")
+set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++17 -D__STDC_FORMAT_MACROS")
Review comment:
```suggestion
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=c++17 -D__STDC_FORMAT_MACROS")
```
why use gnu++17 rather than c++17
##########
File path: env.sh
##########
@@ -55,12 +55,19 @@ if [[ -z ${DORIS_GCC_HOME} ]]; then
fi
gcc_ver=`${DORIS_GCC_HOME}/bin/gcc -dumpfullversion -dumpversion`
-required_ver="5.3.1"
+required_ver="7.1.0"
if [[ ! "$(printf '%s\n' "$required_ver" "$gcc_ver" | sort -V | head -n1)" =
"$required_ver" ]]; then
echo "Error: GCC version (${gcc_ver}) must be greater than or equal to
${required_ver}"
exit 1
fi
+flex_ver=`flex --version | awk '{print $2}'`
Review comment:
why do this check? and update flex version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
