HappenLee commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427247372



##########
File path: env.sh
##########
@@ -55,12 +55,19 @@ if [[ -z ${DORIS_GCC_HOME} ]]; then
 fi
 
 gcc_ver=`${DORIS_GCC_HOME}/bin/gcc -dumpfullversion -dumpversion`
-required_ver="5.3.1"
+required_ver="7.1.0"
 if [[ ! "$(printf '%s\n' "$required_ver" "$gcc_ver" | sort -V | head -n1)" = 
"$required_ver" ]]; then 
     echo "Error: GCC version (${gcc_ver}) must be greater than or equal to 
${required_ver}"
     exit 1
 fi
 
+flex_ver=`flex --version | awk '{print $2}'`

Review comment:
       Because the C++ code generated by flex uses the keyword ```register```.
   
   From C++11 deprecated the ```register``` keyword.  
   
   In C++17 forbidden use ```register``` keyword.  flex fix the problem after 
2.6.0 version.
   
   reference: https://github.com/westes/flex/issues/132




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to