BiteTheDDDDt commented on code in PR #19343:
URL: https://github.com/apache/doris/pull/19343#discussion_r1187115666
##########
be/src/olap/field.h:
##########
@@ -642,22 +661,21 @@ class FieldFactory {
default:
return new Field(column);
}
- case OLAP_FIELD_AGGREGATION_HLL_UNION:
+ case FieldAggregationMethod::OLAP_FIELD_AGGREGATION_HLL_UNION:
return new HllAggField(column);
- case OLAP_FIELD_AGGREGATION_BITMAP_UNION:
+ case FieldAggregationMethod::OLAP_FIELD_AGGREGATION_BITMAP_UNION:
return new BitmapAggField(column);
- case OLAP_FIELD_AGGREGATION_QUANTILE_UNION:
+ case FieldAggregationMethod::OLAP_FIELD_AGGREGATION_QUANTILE_UNION:
return new QuantileStateAggField(column);
- case OLAP_FIELD_AGGREGATION_UNKNOWN:
- LOG(WARNING) << "WOW! value column agg type is unknown";
- return nullptr;
+ case FieldAggregationMethod::OLAP_FIELD_AGGREGATION_UNKNOWN:
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
