HappenLee commented on code in PR #19343:
URL: https://github.com/apache/doris/pull/19343#discussion_r1187639563
##########
be/src/olap/olap_common.h:
##########
@@ -149,14 +149,14 @@ enum class FieldType {
// Note that in practice, not all types can use all the following aggregation
methods
// For example, it is meaningless to use SUM for the string type (but it will
not cause the program to crash)
// The implementation of the Field class does not perform such checks, and
should be constrained when creating the table
-enum FieldAggregationMethod {
+enum class FieldAggregationMethod {
OLAP_FIELD_AGGREGATION_NONE = 0,
OLAP_FIELD_AGGREGATION_SUM = 1,
OLAP_FIELD_AGGREGATION_MIN = 2,
OLAP_FIELD_AGGREGATION_MAX = 3,
OLAP_FIELD_AGGREGATION_REPLACE = 4,
OLAP_FIELD_AGGREGATION_HLL_UNION = 5,
- OLAP_FIELD_AGGREGATION_UNKNOWN = 6,
Review Comment:
add a new enum, do not change origin value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
