TangSiyang2001 commented on code in PR #19392:
URL: https://github.com/apache/doris/pull/19392#discussion_r1187349634
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java:
##########
@@ -77,17 +77,19 @@ public class BrokerLoadJob extends BulkLoadJob {
private Profile jobProfile;
// If set to true, the profile of load job with be pushed to ProfileManager
private boolean enableProfile = false;
+ private String cluster;
// for log replay and unit test
public BrokerLoadJob() {
super(EtlJobType.BROKER);
}
public BrokerLoadJob(long dbId, String label, BrokerDesc brokerDesc,
- OriginStatement originStmt, UserIdentity userInfo)
+ String cluster, OriginStatement originStmt,
UserIdentity userInfo)
Review Comment:
Maybe we could merge the field `cluster` into BrokerDesc temporarily, and in
our Load refactor task, field `cluster` can be included under the semantic of
`resource_desc`, what's ur opinion?
If agreement reached, then the access to cluster can become
getBrokerDesc().getCluster() (or getResourceDesc().getCluster() after our load
refactor task).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
