lvshaokang commented on PR #19392: URL: https://github.com/apache/doris/pull/19392#issuecomment-1539351756
@TangSiyang2001 As I can see, SparkLoadJob's cluster uses `resource.getName`, which declares a required field for a resource. But the `BY cluster` for BrokerLoad is an optional item, which only serves as a flag, and is not called anywhere else. Also, I looked at the syntax commit record for `BY cluster` and I think maybe it is a historical reserved field and there should be no compatibility issues if removing it. Another to discuss it, if we use the second way, the broker load has a name attribute(`WITH Broker name`) , while the s3 load does not have a name attribute, and when it doesn't, we use the default value`default_cluster` as the cluster. So, there are 2 point need discussed: 1.remove `by cluster` syntax support 2.use broker name as cluster Looking forward your reply~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
