morningman commented on a change in pull request #3702:
URL: https://github.com/apache/incubator-doris/pull/3702#discussion_r430972569
##########
File path: be/src/exprs/json_functions.h
##########
@@ -72,6 +72,7 @@ class JsonFunctions {
/**
* The `document` parameter must be has parsed.
+ * return Value Is Array object
Review comment:
better to change its name to `get_json_array_from_parsed_json()` to make
it more explict.
And in `src//exec/json_scanner.cpp` line 270, you can this method, but judge
the return value as either array or non-array? the `else` should not happen?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
