worker24h commented on a change in pull request #3702:
URL: https://github.com/apache/incubator-doris/pull/3702#discussion_r430977156
##########
File path: be/src/exprs/json_functions.h
##########
@@ -72,6 +72,7 @@ class JsonFunctions {
/**
* The `document` parameter must be has parsed.
+ * return Value Is Array object
Review comment:
The method MUST return ArrayObject.
`else if (!root->IsArray())` is true, then I warp a ArrayObject in `root`
outside.
`else` case MUST be ArrayObject
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]