morningman commented on a change in pull request #3762:
URL: https://github.com/apache/incubator-doris/pull/3762#discussion_r435986050
##########
File path: be/src/olap/memory/mem_tablet.h
##########
@@ -27,6 +27,15 @@ class MemSubTablet;
class ScanSpec;
class MemTabletScan;
class WriteTxn;
+class MemTablet;
+using MemTabletSharedPtr = std::shared_ptr<MemTablet>;
+
+inline MemTabletSharedPtr to_mem_tablet(const BaseTabletSharedPtr& base) {
+ if (base->is_memory()) {
+ return std::static_pointer_cast<MemTablet>(base);
+ }
+ return MemTabletSharedPtr();
Review comment:
Is this a incomplete implementation? If yes, better add a TODO
##########
File path: be/src/olap/tablet.h
##########
@@ -46,47 +46,27 @@ class TabletMeta;
using TabletSharedPtr = std::shared_ptr<Tablet>;
+inline TabletSharedPtr to_tablet(const BaseTabletSharedPtr& base) {
+ if (base->is_memory()) {
+ return TabletSharedPtr();
Review comment:
incomplete?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
