decster commented on a change in pull request #3762:
URL: https://github.com/apache/incubator-doris/pull/3762#discussion_r436441988
##########
File path: be/src/olap/tablet.h
##########
@@ -46,47 +46,27 @@ class TabletMeta;
using TabletSharedPtr = std::shared_ptr<Tablet>;
+inline TabletSharedPtr to_tablet(const BaseTabletSharedPtr& base) {
+ if (base->is_memory()) {
+ return TabletSharedPtr();
Review comment:
Why is this incomplete? This utility function for pointer conversion is
only used in some internal code, another option is inline them, because, after
inlining, some logic is redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
