worker24h commented on a change in pull request #4020:
URL: https://github.com/apache/incubator-doris/pull/4020#discussion_r449954852
##########
File path: be/src/exec/json_scanner.cpp
##########
@@ -471,10 +530,14 @@ Status JsonReader::handle_nest_complex_json(Tuple* tuple,
const std::vector<Slot
* value1 10
* value2 30
*/
-Status JsonReader::handle_flat_array_complex_json(Tuple* tuple, const
std::vector<SlotDescriptor*>& slot_descs, MemPool* tuple_pool, bool* eof) {
+Status JsonReader::_handle_flat_array_complex_json(Tuple* tuple, const
std::vector<SlotDescriptor*>& slot_descs, MemPool* tuple_pool, bool* eof) {
do {
- if (_next_line >= _total_lines) {//parse json and generic document
- RETURN_IF_ERROR(parse_json_doc(eof));
+ if (_next_line >= _total_lines) {
+ Status st = _parse_json_doc(eof);
+ if (st.is_data_quality_error()) {
+ continue; // continue to read next
+ }
+ RETURN_IF_ERROR(st); // terminate if encounter other errors
Review comment:
I think that this code can be deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
