worker24h commented on a change in pull request #4020:
URL: https://github.com/apache/incubator-doris/pull/4020#discussion_r449959852
##########
File path: be/src/exec/json_scanner.cpp
##########
@@ -524,21 +593,21 @@ Status JsonReader::handle_flat_array_complex_json(Tuple*
tuple, const std::vecto
return Status::OK();
}
-Status JsonReader::handle_complex_json(Tuple* tuple, const
std::vector<SlotDescriptor*>& slot_descs, MemPool* tuple_pool, bool* eof) {
+// handle json with specified json path
+Status JsonReader::_handle_complex_json(Tuple* tuple, const
std::vector<SlotDescriptor*>& slot_descs, MemPool* tuple_pool, bool* eof) {
if (_strip_outer_array) {
- return handle_flat_array_complex_json(tuple, slot_descs, tuple_pool,
eof);
+ return _handle_flat_array_complex_json(tuple, slot_descs, tuple_pool,
eof);
} else {
- return handle_nest_complex_json(tuple, slot_descs, tuple_pool, eof);
+ return _handle_nested_complex_json(tuple, slot_descs, tuple_pool, eof);
}
}
+//
Review comment:
Delete it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
