caiconghui commented on a change in pull request #4089:
URL: https://github.com/apache/incubator-doris/pull/4089#discussion_r454766786
##########
File path: fe/src/main/java/org/apache/doris/catalog/Replica.java
##########
@@ -318,12 +318,17 @@ private void updateReplicaInfo(long newVersion, long
newVersionHash,
long lastFailedVersion, long lastFailedVersionHash,
long lastSuccessVersion, long lastSuccessVersionHash,
long newDataSize, long newRowCount) {
- LOG.debug("before update: {}", this.toString());
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("before update: {}", this.toString());
+ }
if (newVersion < this.version) {
- // yiguolei: could not find any reason why new version less than
this.version should run???
- LOG.warn("replica {} on backend {}'s new version {} is lower than
meta version {}",
- id, backendId, newVersion, this.version);
+ // This case means that replica meta version has been updated by
ReportHandler before
Review comment:
@yangzhg
for example, now, the publish version daemon send publish verison task(2 3 4
5 6) to one be, and the be finish all publish version task, its replica version
is 6 now, but publish version daemon need wait other be finish all publish
version, now the replica version in fe may be 4, I think it is the common case
that be replica version higher than fe replica version, when ReportHandler sync
tablet. And now publish version daemon finish txn and replica version 4 + 1 =
5, it find the newer version(5) is lower than replica version(6) in fe.
https://github.com/apache/incubator-doris/blob/14ac49dde557b54e9578d91f9dba7e148e5c975b/fe/src/main/java/org/apache/doris/master/ReportHandler.java#L473-L477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
