morningman commented on a change in pull request #4089:
URL: https://github.com/apache/incubator-doris/pull/4089#discussion_r455117606
##########
File path: fe/src/main/java/org/apache/doris/catalog/Replica.java
##########
@@ -318,12 +318,17 @@ private void updateReplicaInfo(long newVersion, long
newVersionHash,
long lastFailedVersion, long lastFailedVersionHash,
long lastSuccessVersion, long lastSuccessVersionHash,
long newDataSize, long newRowCount) {
- LOG.debug("before update: {}", this.toString());
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("before update: {}", this.toString());
+ }
if (newVersion < this.version) {
- // yiguolei: could not find any reason why new version less than
this.version should run???
- LOG.warn("replica {} on backend {}'s new version {} is lower than
meta version {}",
- id, backendId, newVersion, this.version);
+ // This case means that replica meta version has been updated by
ReportHandler before
Review comment:
Good explaination. I suggest to add this directly to the comment.
##########
File path: fe/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1117,5 +1117,13 @@
*/
@ConfField
public static String thrift_server_type = ThriftServer.THREAD_POOL;
+
+ /**
+ * This config will decide whether to resend agent task when create_time
for agent_task is set,
+ * only when current_time - create_time > agent_task_resend_wait_time_ms
can ReportHandler do resend agent task
+ */
+ @ConfField
Review comment:
```suggestion
@ConfField (mutable = true, masterOnly = true)
```
##########
File path: docs/en/administrator-guide/config/fe_config.md
##########
@@ -110,6 +110,10 @@ There are two ways to configure FE configuration items:
## Configurations
+### `agent_task_resend_wait_time_ms`
+
+当代理任务的创建时间被设置的时候，此配置将决定是否重新发送代理任务，
当且仅当当前时间减去创建时间大于agent_task_task_resend_wait_time_ms时，ReportHandler可以重新发送代理任务。
Review comment:
```suggestion
当代理任务的创建时间被设置的时候，此配置将决定是否重新发送代理任务， 当且仅当当前时间减去创建时间大于
`agent_task_task_resend_wait_time_ms` 时，ReportHandler可以重新发送代理任务。
```
建议增加说明该设置解决的问题和最佳实践
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
