wsjz commented on code in PR #23319:
URL: https://github.com/apache/doris/pull/23319#discussion_r1304013077
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -53,6 +53,12 @@ statement
(PARTITION partition=identifierList)?
(USING relation (COMMA relation)*)
whereClause #delete
+ | EXPORT TABLE tableName=multipartIdentifier
+ (PARTITION partition=identifierList)?
+ (whereClause)?
+ TO filePath=constant
+ (PROPERTIES LEFT_PAREN fileProperties+=tvfProperty (COMMA
fileProperties+=tvfProperty)* RIGHT_PAREN)?
Review Comment:
1.can extract it to departed clause? see following withRemoteStorageSystem
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -82,6 +88,22 @@ planType
| ALL // default type
;
+withRemoteStorageSystem
+ : WITH S3 LEFT_PAREN
+ brokerProperties+=remoteStorageProperty (COMMA
brokerProperties+=remoteStorageProperty)*
+ RIGHT_PAREN
+ | WITH HDFS LEFT_PAREN
+ brokerProperties+=remoteStorageProperty (COMMA
brokerProperties+=remoteStorageProperty)*
Review Comment:
2. it is same as `PROPERTIES LEFT_PAREN fileProperties+=tvfProperty (COMMA
fileProperties+=tvfProperty)* RIGHT_PAREN)`, extract to new clause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
