wsjz commented on code in PR #23319:
URL: https://github.com/apache/doris/pull/23319#discussion_r1303947034
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -82,6 +88,22 @@ planType
| ALL // default type
;
+withRemoteStorageSystem
+ : WITH S3 LEFT_PAREN
+ brokerProperties+=remoteStorageProperty (COMMA
brokerProperties+=remoteStorageProperty)*
+ RIGHT_PAREN
+ | WITH HDFS LEFT_PAREN
+ brokerProperties+=remoteStorageProperty (COMMA
brokerProperties+=remoteStorageProperty)*
+ RIGHT_PAREN
+ | WITH LOCAL LEFT_PAREN
+ brokerProperties+=remoteStorageProperty (COMMA
brokerProperties+=remoteStorageProperty)*
+ RIGHT_PAREN
+ | WITH BROKER brokerName=constant
Review Comment:
if use constant, just support `WITH BROKER "s3"`, but can't compatible with
`WITH BROKER s3`
maybe use WITH BROKER brokerName=identifierOrText instead of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
